Skip to content
This repository has been archived by the owner on Mar 29, 2023. It is now read-only.

Badges #100

Draft
wants to merge 73 commits into
base: development
Choose a base branch
from
Draft

Badges #100

wants to merge 73 commits into from

Conversation

rubenhorn
Copy link
Collaborator

Closes #99

⚠This branch is "work in progress".

@rubenhorn rubenhorn mentioned this pull request Feb 20, 2022
3 tasks
edreinoso added 30 commits April 8, 2022 18:02
…ollaction_backend into feat/gh-111/badge_threshold

# Resolved Conflicts:
#	docs/api2.yaml
commit 29442c1
Merge: 9a473b1 fd30c56
Author: Ed Reinoso <[email protected]>
Date:   Sat Jun 11 19:03:51 2022 +0200

    Merge branch 'development' into feat/gh-73/crowdactions

commit 9a473b1
Author: Ed Reinoso <[email protected]>
Date:   Sat Jun 11 19:00:07 2022 +0200

    returning crowdaction object

commit fd30c56
Merge: d189c2d 15a4d6e
Author: Mathias Mogensen <[email protected]>
Date:   Wed May 18 09:40:16 2022 +0200

    Merge pull request #132 from CollActionteam/feat/gh-73/crowdactions

    Feat/gh 73/crowdactions

commit 15a4d6e
Author: Ruben Horn <[email protected]>
Date:   Tue May 17 23:26:57 2022 +0200

    comment out cms endpoint (revisit later)

commit 9f8fb11
Merge: 141e144 d189c2d
Author: Ed Reinoso <[email protected]>
Date:   Sun May 15 09:28:12 2022 +0200

    Merge branch 'development' of github.com:CollActionteam/collaction_backend into feat/gh-73/crowdactions

commit 141e144
Author: Ed Reinoso <[email protected]>
Date:   Sun May 15 09:24:31 2022 +0200

    ⚡️ scan operations on crowdactions

commit 2dd48b2
Author: Ed Reinoso <[email protected]>
Date:   Sun May 15 09:23:20 2022 +0200

    ⚡️ mock create crowdaction

commit d189c2d
Merge: 3fb6e82 dce91c7
Author: Mathias Mogensen <[email protected]>
Date:   Thu May 5 21:50:41 2022 +0200

    Merge pull request #129 from CollActionteam/fix/contact-form-unit-tests

    Expect recipient also as sender in tests

commit dce91c7
Author: Ruben Horn <[email protected]>
Date:   Thu May 5 21:43:56 2022 +0200

    Expect recipient also as sender in tests

commit 3fb6e82
Merge: 1366e1e 7a51f51
Author: Ruben Horn <[email protected]>
Date:   Thu May 5 21:31:00 2022 +0200

    Merge pull request #128 from CollActionteam/fix/email-contact-not-registered

    Use registered address as both sender and recipient

commit 7a51f51
Author: Ruben Horn <[email protected]>
Date:   Thu May 5 21:29:15 2022 +0200

    Use registered address as both sender and recipient

commit 1366e1e
Merge: 93bb124 8b63733
Author: Mathias Mogensen <[email protected]>
Date:   Thu May 5 20:50:42 2022 +0200

    Merge pull request #126 from CollActionteam/fix/app-version-regex

    Fixed regex

commit 8b63733
Author: Ruben Horn <[email protected]>
Date:   Thu May 5 20:49:57 2022 +0200

    Fixed regex

    s. https://regexr.com/6l215

commit 93bb124
Author: Ed Reinoso <[email protected]>
Date:   Sun Apr 17 23:15:50 2022 +0200

    Feat/gh 73/crowdactions (#119)

    * 🚀 crowdaction hex refactoring init

    * 🚧  dynamodb manager repository, pt1: init

    * ⚡️ launching own sam config

    * 🚧 [crowdaction] deployed first function on to aws

    * 🚧 [crowdaction] removing extra copy of dynamo repository

    * 🚧 [crowdaction] init model and validation on request

    * 🚧 [crowdaction] changed the model function names

    * 🚧 [crowdaction] working on internal and handler

    * 🚧 [crowdaction] simple version of GET request by ID

    * 🚧 [crowdaction] testing GET request by ID

    * 🚧 [crowdaction] creating external function to GET crowdaction by ID

    * 🚧 [crowdaction] including query function in ddb repository

    * 🚧 [crowdaction] initial code base for GET crowdactions by status

    * 🚧 [crowdaction] cleaning up, commitment options

    * 🚧 [crowdaction] including the mock repository for dynamo and crowdaction

    * 🚧 [crowdaction] modifying the mock repository to include GetCrowdactionByStatus

    * 🚧 [crowdaction] removed unnecessary comments, per the feedback on pull request

    * [pull request] removing samconfig file from history

    * [pull request] ignoring samconfig file as per the pull request

    * [pull request] modified naming for the internal interface

    * [pull request] getting rid of useless else statement

    * [pull request] removing dynamodb dependencies in logic

    * [pull request] including mock repository and crowdaction test

    * [pull request] cleaning up some unnecessary lines

    * [pull request] separating repository concerns

    * [pull request] modifying test cases with new repository structure

    * [pull request] changing dynamo repository call from crowdaction main handler

    * [pull request] changing parameters to pass unit test case

    * [pull request] changing crowdactionID from test case

    * [pull request] changing method call for crowdaction test

    * [pull request] fixing parameter issue in crowdaction_test

    * [pull request] testing issue with the args.get(x) call in mock/dynamo repository

    * [pull request] including Mock in each of the function calls from the dynamo repository

    * [pull request] modifying test cases for crowdaction

    * [pull request] changes done based on feedback

    [pull request] ignoring samconfig file as per the pull request

    [pull request] modified naming for the internal interface

    [pull request] getting rid of useless else statement

    [pull request] removing dynamodb dependencies in logic

    [pull request] including mock repository and crowdaction test

    [pull request] cleaning up some unnecessary lines

    [pull request] separating repository concerns

    [pull request] modifying test cases with new repository structure

    [pull request] changing dynamo repository call from crowdaction main handler

    [pull request] changing parameters to pass unit test case

    [pull request] changing crowdactionID from test case

    [pull request] changing method call for crowdaction test

    [pull request] fixing parameter issue in crowdaction_test

    [pull request] testing issue with the args.get(x) call in mock/dynamo repository

    [pull request] including Mock in each of the function calls from the dynamo repository

    [pull request] modifying test cases for crowdaction

    * [pull request] removing unnecessary hello world

    * [pull request] removing some unnecessary comments

    * final changes before merging

    This commit starts by containing the separation between the post and the get methods that will be used for handling crowdactions

    * removing a duplicate package

    When merged, the net/http packe was imported twice by accident

    * [pull request] cleaning up some final comments

    This should be the last commit before merging to development.

    The implementation includes the initial basis for the /post endpoint to create crowdactions from the CMS.

    The continuation of this task (/post) should be done ideally in the CMS task (up for a discussion, of course) but could expanded somewhere else for other purposes.

    For example, the badge issue may implement a very rudimentary version of this /post crowdaction for testing purposes.

    * changing the crowdaction test case

commit 854d2bc
Author: Ed Reinoso <[email protected]>
Date:   Sun Apr 17 14:28:41 2022 +0200

    changing the crowdaction test case

commit 188f7b3
Author: Ed Reinoso <[email protected]>
Date:   Sun Apr 17 11:35:33 2022 +0200

    [pull request] cleaning up some final comments

    This should be the last commit before merging to development.

    The implementation includes the initial basis for the /post endpoint to create crowdactions from the CMS.

    The continuation of this task (/post) should be done ideally in the CMS task (up for a discussion, of course) but could expanded somewhere else for other purposes.

    For example, the badge issue may implement a very rudimentary version of this /post crowdaction for testing purposes.

commit e7a3d2a
Merge: eb3b973 9ac0b81
Author: Ruben Horn <[email protected]>
Date:   Sat Apr 16 19:57:25 2022 +0200

    Merge pull request #123 from CollActionteam/Automated-security-scanning

    Automated-security-scanning

commit f1e7306
Author: Ed Reinoso <[email protected]>
Date:   Fri Apr 15 21:25:11 2022 +0200

    removing a duplicate package

    When merged, the net/http packe was imported twice by accident

commit f8e0936
Merge: b9dd8b7 eb3b973
Author: Ed Reinoso <[email protected]>
Date:   Fri Apr 15 21:23:54 2022 +0200

    Merge branch 'development' of github.com:CollActionteam/collaction_backend into feat/gh-73/crowdactions

    # Conflicts:
    #	pkg/handler/aws/emailContact/main.go

commit b9dd8b7
Author: Ed Reinoso <[email protected]>
Date:   Fri Apr 15 21:18:53 2022 +0200

    final changes before merging

    This commit starts by containing the separation between the post and the get methods that will be used for handling crowdactions

commit 9ac0b81
Author: Ruben Horn <[email protected]>
Date:   Fri Apr 15 12:04:21 2022 +0200

    Create codeql-analysis.yml

commit eb3b973
Merge: 8626468 824b5ed
Author: Ruben Horn <[email protected]>
Date:   Mon Apr 11 01:07:09 2022 +0200

    Merge pull request #122 from CollActionteam/bugfix/contact_valication

    fix app version validation

commit 8626468
Author: Sobowale-Olayiwola <[email protected]>
Date:   Sun Apr 10 22:57:37 2022 +0100

    [Refactoring] [Arch] Upload Profile Picture (#77)

    * Added interfaces for profile images upload

    * Implmented repository functions

    * created handler for profile pics upload

    * Updated code based on reviews

    * Removed comments based on reviews

    * Added mock and test

    * Updated template.yaml

    * Removed deferred recovery function call and updated error msg

    * Update pkg/repository/aws/uploadProfilePictureManager.go

    Co-authored-by: Mohammad Rajabloo <[email protected]>

    * Fixed changes regarding review

    Co-authored-by: Ruben Horn <[email protected]>
    Co-authored-by: Mohammad Rajabloo <[email protected]>

commit 824b5ed
Author: Mohammad Rajabloo <[email protected]>
Date:   Mon Apr 11 00:42:43 2022 +0430

    fix app version validation
for now these functions are written in python, but it would be great to move it to go at some point
laid out the steps that needed to be done in order to accomplish the task
recursing through the tree to get key and value (ideally) of each commitment option from the crowdaction
parameters and some comments were made
included proper participation, smaller time for expiration and more accurate point rewarding
these changes are related mainly to the crowdaction_id, and also the deletion of event and permission from lambda
created a different class for the different ops, create user, crowdaction and profile
copied the latest changes from the lambda function
cleaned up a bit with some comments and terminologies
these errors were causing validation errors when recording the participation
to automatically delete all the test cases that are created from the script
this change should represent the correct interpretation of the commitment tree, otherwise there would be a validation error from the backend
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Badges
2 participants