Multiline error

[sigmaprojects]

JSMin will fail on strings like so:
var foo = ' bar
these
are \
new lines';
A test case (and how I came across this issue) was trying to minify this library: http://www.no-margin-for-errors.com/projects/prettyphoto-jquery-lightbox-clone/
Tried both the packages (minified / dev) with the same result - Though manually editing the library and concatenating all the \ instances fixes it, but that's not ideal.

The error is correctly thrown on line 189 of JSMin.java

Maybe if JSMin can't fix this by itself, have it include the js file without trying to minify it?

[lmajano]

So should it remove the /?

Luis Majano
CEO
Ortus Solutions, Corp
www.ortussolutions.com
www. luismajano.com
www.coldbox.org
www.gocontentbox.org
P/F: 1-888-557-8057
Cell: 1-909-248-3408

On Sunday, April 15, 2012 at 1:20 AM, Don Quist wrote:

JSMin will fail on strings like so:
var foo = ' bar
these
are \
new lines';
A test case (and how I came across this issue) was trying to minify this library: http://www.no-margin-for-errors.com/projects/prettyphoto-jquery-lightbox-clone/
Tried both the packages (minified / dev) with the same result - Though manually editing the library and concatenating all the \ instances fixes it, but that's not ideal.

The error is correctly thrown on line 189 of JSMin.java

Maybe if JSMin can't fix this by itself, have it include the js file without trying to minify it?

---

Reply to this email directly or view it on GitHub:
#2

[sigmaprojects]

That would be nice, and I would prefer it that way - but it could also break some things that rely on parsing strings by new lines...

[lmajano]

So what could be the solutions?

Luis Majano
CEO
Ortus Solutions, Corp
www.ortussolutions.com

ColdBox Platform: http://www.coldbox.org
Linked In: http://www.linkedin.com/pub/3/731/483
Social: twitter.com/ortussolutions | twitter.com/coldbox | twitter.com/lmajano

On Apr 18, 2012, at 3:15 AM, Don [email protected] wrote:

That would be nice, and I would prefer it that way - but it could also break some things that rely on parsing strings by new lines...

---

Reply to this email directly or view it on GitHub:
#2 (comment)

[bdw429s]

You need to include the latest from Douglas Crockford's original C implementation that the Java port is based off of.
https://github.com/douglascrockford/JSMin/blob/master/jsmin.c
From what I've read online, he's fixed this issue already.

[lmajano]

Is this still an issue?