Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn about / reject local file headers which have a data descriptor but don't use deflate compression #21

Open
NeRdTheNed opened this issue Jul 5, 2023 · 0 comments
Labels
enhancement New feature or request idea

Comments

@NeRdTheNed
Copy link
Contributor

Parsing just a local file header which uses a data descriptor is technically not reliable when it uses stored (uncompressed) data. A malicious actor could theoretically insert a local file header or data descriptor header at an arbitrary point to confuse parsing. Deflate compressed streams are self terminating, so they don't suffer from the same problem. If the size of an entry is only read from the central directory file header, this isn't a problem, but JVM zip parsing rejects such local file headers anyway.

@Col-E Col-E added enhancement New feature or request idea labels Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request idea
Projects
None yet
Development

No branches or pull requests

2 participants