You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
the token file is edited by hand, a more human readable 4 spaces is appropriate, the spoiler file is created automatically and is currently downloaded by the client uncompressed, a bandwidth saving but still human readable 2 spaces is appropriate.
we don't really have a guideline on how our xmls are formatted, it's mostly a machine read format that has whitespace as optional.
oracle's 4 space file is machine generated, using 2 spaces would noticeably reduce its size (from 44MB to 38MB according to my estimate) but such a change is not very significant considering the app quickly occupies this amount of space after downloading one deck of card images. If this use of disk space were an issue, we'd gain more efficiency compressing the xml than reducing the indentation.
There's no obvious storage space issue and since it is XML there's an implication that it should be legible. So do you think 4 spaces or 2 spaces is more legible, and if your answer is 2, do you think enough people would agree to change the Oracle output?
I realized that we use 4 spaces for the "Token" file:
https://raw.githubusercontent.com/Cockatrice/Magic-Token/refs/heads/master/tokens.xml
But only 2 spaces in the "Spoiler" file:
https://raw.githubusercontent.com/Cockatrice/Magic-Spoiler/refs/heads/files/spoiler.xml
Would like to see that harmonized across XML files in the project.
(cards.xml generated by Oracle uses 4 spaces, not sure if using only 2 would reduce the file size even, considering the huge amount of cards in there)
The text was updated successfully, but these errors were encountered: