Fixed the right overflow of small cards in the cards section. #199
Conversation
jaivsh
changed the title
jaivsh
changed the title
| 8, | ||
| child: const Column( | ||
| 32, | ||
| child: Column( |
There was a problem hiding this comment.
Use const before Column as there is not dynamic data associated with it .
There was a problem hiding this comment.
Hello Sir, I've modified the PR and implemented the const wherever possible. However, im using the latest version of flutter, and as per it, there have been modifications made by the dart and flutter in its new versions, which does not allow const in specific places, like in line 17-18 above as you mentioned. Thank you!
| @@ -11,11 +11,11 @@ class SixthCard extends StatelessWidget { | |||
| Container( | |||
| color: Colors.black, | |||
| padding: const EdgeInsets.only(left: 5, top: 2, bottom: 2), | |||
| height: (MediaQuery.of(context).size.width / 2.4) * 0.83, | |||
| height: (MediaQuery.of(context).size.width / 2.4) * 0.95, | |||
There was a problem hiding this comment.
The cards are still overflowing in my phone . Please fix it .
There was a problem hiding this comment.
After fixing these let me know
There was a problem hiding this comment.
@ashdude1401 Sir, I've implemented the changed for each specific card. Have confirmed it by running the app on smaller sized emulators. Please have a review!!
Also, I've implemented the const wherever possible. However, im using the latest version of flutter, and as per it, there have been modifications made by the dart and flutter in its new versions, which does not allow const in specific places, like in line 17 above as you mentioned. Thanks!
There was a problem hiding this comment.
@jaivsh I have checked again it is still overflowing in phone, you have make make it responsive for all the screen .All phone screen are not covered by emulator I think mine is one of them .My screen screen size is 6.8 inch. Some screen you have to handle separately and secondly , I on the latest version of flutter and dart , it is still showing me the suggestion of adding const at line 17 .So, please these issue again and let me know once you are done.
|
@jaivsh There are a lot of merge conflicts due to the merge of a similar PR. Can you make a new commit to fix all these conflicts? |
Pull Request Template
Description:
I've modified the card-design in such a way such that it doesn't overflow on any screen size, ranging from a large sized tablet to a small sized smartphone.
Changes Made:
-Modified the design of the card so as to allow itself to be more accomodative while adhering to the basic layout of all the cards.
Related Issue:
fixed #196
Screenshots/GIFs:
Testing Done:
I've tested the modification in the following emulators in android studio:
Checklist:
Please review and merge this PR at your earliest convenience.
Thank you!