Fix/templatestorage #1298
Closed
Fix/templatestorage #1298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, thanks for the PR and sorry for the late reply on this one. I've fixed this issue in the network refactor branch and it will probably be included in the next release: 8ea6b75 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Downloading files from the Wrapper via the TemplateStorage has a synchronization bug
More information in #1294
Modification
Most important change: Moved the RemoteTemplateStorage from the driver to the wrapper
Unless there is some future API planned, this should be fine because the RemoteTemplateStorage is only used in the wrapper and as far as I understand it remote storages from node to node are not allowed.
Otherwise in RemoteTemplateStorage I had to add a reference to the TemplateStorageCallbackListener which modifies the creation all the way up to the Wrapper class
Most of the logic itself is in the TemplateStorageCallbackListener, we could refactor the logic to somewhere else but my opinion is: what's the point?
I also modified temporary file creation. This could be left out, but it really is smarter not give the possibility to overwrite temporary files someone else created
Result
the TemplateStorage API works again
Other context
Fixes #1294