-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add command to display the stderr data from submission in terminal #252
base: master
Are you sure you want to change the base?
Add command to display the stderr data from submission in terminal #252
Conversation
Hi @vkartik97, thanks for replying on the task page but I still can't find your review. Could you recomment it please? |
|
Yes |
The comment is in pending status, so pasting here again: |
@vkartik97 That is because I tried to make |
@vkartik97 I personally feel the same thing to you, so I am willing to make another PR that takes in the code of the functions in |
If you are going ahead for making PR as commented by you, can you only try for |
Sure but can I ask why? |
The refactoring will be less as compared to going for both result and submission. Once we are satisfied with the changes in |
@vkartik97 I got it. Created #253. |
I fell good about the change made in #253. What do you think @vkartik97? |
@Ram81 @RishabhJain2018 Could you also take a look? |
I closed by accident |
Apart from #253, what do you think of the changes made in this PR? |
The PR for #253 seems good, but is of independent of this task. So, approving this, as refactoring can be a new task altogether. |
The corresponding GCI task
Changes:
evalai submission SUBMISSION_ID stderr
.CC: @vkartik97 utsav @Ram81 @RishabhJain2018