Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing (un)install-autocomplete.sh and their related bin entries within package.json #762

Open
florian-sanders-cc opened this issue Jun 17, 2024 · 0 comments

Comments

@florian-sanders-cc
Copy link
Contributor

Context

When submitting the nixpkgs PR (see NixOS/nixpkgs#319818), the reviewer rightfully pointed out that our package was creating install-clever-completion and uninstall-clever-completion binaries in addition to the clever one.

This is based on the bin entry within our package.json:

"bin": {
    "clever": "bin/clever.js",
    "install-clever-completion": "scripts/install-autocomplete.sh",
    "uninstall-clever-completion": "scripts/uninstall-autocomplete.sh"
  },

Since completion installation seems to be handled through cliparse anyway (cf cliparse - README.md - Autocompletion), do we still need these scripts and their related entries within the bin section?

I don't know much about the project so feel free to close this if these files / entries are still relevant and used, it's mostly a housekeeping problem but it does not create any issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant