Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: option to have process tree entries be collapsed by default #1627

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Bucket-Bucket-Bucket
Copy link

Description

A description of the change, what it does, and why it was made. If relevant (such as any change that modifies the UI), please provide screenshots of the changes:

Adds a command line option and config file option to have the process tree view have all entries collapsed by default.

Issue

If applicable, what issue does this address?

Closes: #1612

Testing

If relevant, please state how this was tested. All changes must be tested to work:

If this is a code change, please also indicate which platforms were tested:

  • Windows
  • macOS
  • Linux

Checklist

If relevant, ensure the following have been met:

  • Areas your change affects have been linted using rustfmt (cargo fmt)
  • The change has been tested and doesn't appear to cause any unintended breakage
  • Documentation has been added/updated if needed (README.md, help menu, doc pages, etc.)
  • The pull request passes the provided CI pipeline
  • There are no merge conflicts
  • If relevant, new tests were added (don't worry too much about coverage)

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 12.00000% with 22 lines in your changes missing coverage. Please review.

Project coverage is 41.95%. Comparing base (196d6d1) to head (ca0abc8).

Files with missing lines Patch % Lines
src/widgets/process_table.rs 0.00% 20 Missing ⚠️
src/app.rs 0.00% 1 Missing ⚠️
src/options/args.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1627       +/-   ##
===========================================
- Coverage   54.73%   41.95%   -12.78%     
===========================================
  Files         114      114               
  Lines       17685    17699       +14     
===========================================
- Hits         9680     7426     -2254     
- Misses       8005    10273     +2268     
Flag Coverage Δ
macos-12 37.40% <12.00%> (-0.02%) ⬇️
ubuntu-latest 43.73% <12.00%> (-13.45%) ⬇️
windows-2019 37.31% <12.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@ClementTsang ClementTsang self-assigned this Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Collapse process tree view by default?
2 participants