Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CONTENT] More Thoughts for Traits #3047

Open
wants to merge 12 commits into
base: development
Choose a base branch
from

Conversation

tobes03
Copy link
Contributor

@tobes03 tobes03 commented Nov 27, 2024

About The Pull Request

Just padding the general trait-locked thoughts.

Why This Is Good For ClanGen

Adds some flavour :)

Proof of Testing

(childish)
image
image
image

(strict)
image

(compassionate)
image

(adventurous)
image

Copy link
Collaborator

@scribblecrumb scribblecrumb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bleh hit the wrong button, meant to request changes, not approve xD

@tobes03
Copy link
Contributor Author

tobes03 commented Nov 28, 2024

wow there were some wacky errors in there. i guess a lot of the errors arose from the time it spent sitting in my drafts lol...

resources/dicts/thoughts/alive/general.json Outdated Show resolved Hide resolved
resources/dicts/thoughts/alive/general.json Outdated Show resolved Hide resolved
resources/dicts/thoughts/alive/general.json Outdated Show resolved Hide resolved
resources/dicts/thoughts/alive/general.json Outdated Show resolved Hide resolved
resources/dicts/thoughts/alive/general.json Show resolved Hide resolved
resources/dicts/thoughts/alive/general.json Outdated Show resolved Hide resolved
resources/dicts/thoughts/alive/general.json Outdated Show resolved Hide resolved
resources/dicts/thoughts/alive/general.json Outdated Show resolved Hide resolved
resources/dicts/thoughts/alive/general.json Outdated Show resolved Hide resolved
resources/dicts/thoughts/alive/general.json Outdated Show resolved Hide resolved
@tobes03
Copy link
Contributor Author

tobes03 commented Nov 28, 2024

Okay I snuck in more edits changing the construction of a lot of verbs. There's no clear consensus on whether thoughts should generally be in the "Verbs" (present) tense or the "Is Verbing" (present continuous). There are some where is makes sense for one over the other, but very often, the present continuous is applied when it just makes the sentence longer and clunky, which is particularly bad for a feature that relies on economy of words. But I might open another branch to edit the thoughts more fully.

@@ -538,7 +538,7 @@
"Has been imitating the Clan leader's behaviour recently",
"Knows {PRONOUN/m_c/subject}{VERB/m_c/'re/'s} a shoo-in for deputy",
"Wonders if the Clan leader talks about {PRONOUN/m_c/object} when {PRONOUN/m_c/subject}{VERB/m_c/'re/'s} not around",
"Tells the Clan leader {PRONOUN/lead_name/subject}{VERB/lead_name/'ve/'s} been doing a wonderful job leading"
"Tells lead_name {PRONOUN/lead_name/subject}{VERB/lead_name/'ve/'s} been doing a wonderful job leading"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure why we're utilizing lead_name here when the r_c cat is already constrained to being the leader? It would be more consistent, imo, if we just used r_c.

Suggested change
"Tells lead_name {PRONOUN/lead_name/subject}{VERB/lead_name/'ve/'s} been doing a wonderful job leading"
"Tells r_c {PRONOUN/r_c/subject}{VERB/r_c/'ve/'s} been doing a wonderful job leading"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants