Change Other Clan Save Data to Use Dictionaries #2897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements enhancement from: ClanGenOfficial#2698 Works with older save files (tested).
The dictionaries always have chosen_symbol as an attribute, checking it was unnecessary.
Runs better, and does the same thing.
|
aaa looks great! :D Thanks for taking this on. Merging will have to wait till after next stable release, though, as we're currently in feature freeze as preparation for that. We can leave this PR open and waiting for now and I'll get it merged once we've started the next development cycle (hopefully soon!) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Change how Other Clan save data is saved and loaded. It is backwards compatible and will not crash or break the game or any saves.
Why This Is Good For ClanGen
Makes expanding on Other Clan related features easier.
Linked Issues
Implements: #2698
Proof of Testing
proof-of-testing_otherclan-save-dict.mp4
Changelog/Credits
Convert Other Clan save data from a series of lists to a list of dictionaries.