Feature: Improvements to keybinds #2459
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # scripts/screens/ListScreen.py
# Conflicts: # scripts/screens/ListScreen.py
…guard against it being impossible to give an injury)
# Conflicts: # scripts/screens/ClanScreen.py # scripts/screens/ListScreen.py # scripts/screens/PatrolScreen.py
…cc_Fix [Bugfix] fixed accessory ceremonies
…-util-log Bugfix: Adds default relationship log text
…-injuries-fix [BUGFIX]: patrol only tries to award injuries that the cat doesn't already have
…borked Fix accessory generation for accessory ShortEvents
…nvited-kit Bugfix: existing kit in clan is not considered new when parent reinvited
Bugfix: Cat List
Fix: Another Pygame-gui update to fix the line spacing
# Conflicts: # scripts/game_structure/ui_elements.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Hi. I'm back at it again. Today, I'd like to share the following keybind things:
New Keybinds
The implementation is partial at the moment as I know scribble is going through and doing some UI work and I don't wanna cause problems for them. I just got Inspired after spotting that bug and yeah, whoops. I would like to see if it's possible to make the entire game controllable via keyboard by tabbing through things & having highlight modes etc but that's kind of far in the future. I just wanted to work on something this afternoon and here we are.
Why This Is Good For ClanGen
Giving some love to the keybind users. I think the ListScreen changes should ignore the keybind toggle - they currently don't, but I think it makes sense.
Linked Issues
Fixes #2456
Proof of Testing
Link to the Discord testing thread
Changelog/Credits