[BUGFIX] added can_have_stat attribute to patrols that reference both p_l and s_c #3091
+104
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Convert issue template to issue form
|
Could I have you PR this to the v0.12.0 branch instead? That way we can get the bugfix into the release version, then we'll just merge release into dev to get the bugfix there too. |
bakermor
changed the title
|
Yeah! It should be to the right branch now |
scribblecrumb
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Added the can_have_stat attribute to patrols that reference both p_l and s_c in the text. If multiple/all cats in the patrol have the stats (including the p_l), only the p_l is prioritized to be the stat cat.
For all the patrols I could find that referenced p_l and s_c, and wouldn't make sense if s_c was p_l, the can_have_stat attribute was set to ["r_c"] or ["not_pl_rc"] to prevent the patrol leader from talking to/interacting with themselves.
Linked Issues
Fixes #3090
Proof of Testing
Before:
Since there was no can_have_stat attribute, if the p_l had the stat then it would always become the s_c. Only the p_l is in the possible_stat_cats list at the end of _get_stat_cat.
After:
Patrol leader is no longer in possible_stat_cats
Changelog/Credits