Fix comparison in possible_lead_den_events for status='former ClanCat' #3057
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
oh. |
scribblecrumb
approved these changes
Nov 29, 2024
|
Thanks for the bugfix! Are you part of our discord server? If you'd like and if you plan to continue contributing, you're eligible to receive dev roles there and access the dev channels. It's not a requirement, though! And if you're welcome to continue contributing without being on the discord. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
In possible_lead_den_events there is a comparison between the cat's status.casefold() ("former clancat") and the event's allowed statuses ("former Clancat") which prevents the event from being added to possible_events.
Linked Issues
Fixes #3056
Also references PR #3025
Proof of Testing
Failure Outcome:
Success Outcome:
Generated Events Before:
Generated Events After:
Changelog/Credits