Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CODE] Change Other Clan save data to use a Dict #2698

Open
scribblecrumb opened this issue Sep 17, 2024 · 0 comments · May be fixed by #2897
Open

[CODE] Change Other Clan save data to use a Dict #2698

scribblecrumb opened this issue Sep 17, 2024 · 0 comments · May be fixed by #2897
Labels
enhancement New features or Change to Existing Features

Comments

@scribblecrumb
Copy link
Collaborator

Description
Currently, Other Clan save data is saved as multiple lists. This is both difficult to read and frustrating when new features require more data to be managed. Ideally, Other Clan data should be moved into a dict format that facilitates future expansions. This needs to be handled carefully to avoid old save corruptions.
@scribblecrumb scribblecrumb added the enhancement New features or Change to Existing Features label Sep 17, 2024
Treefire33 added a commit to Treefire33/clangen that referenced this issue Sep 21, 2024
@Treefire33
other_clan save data now uses dicts
ef9c640 
Implements enhancement from: ClanGenOfficial#2698
Works with older save files (tested).
@Treefire33 Treefire33 linked a pull request Oct 14, 2024 that will close this issue
Open
@scribblecrumb scribblecrumb linked a pull request Oct 22, 2024 that will close this issue
Change Other Clan Save Data to Use Dictionaries #2897
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New features or Change to Existing Features
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change Other Clan Save Data to Use Dictionaries Treefire33/clangen
1 participant
@scribblecrumb