Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] various text fixes #2712

Merged
merged 23 commits into from
Sep 22, 2024

Conversation

selkirks
Copy link
Contributor

@selkirks selkirks commented Sep 20, 2024

About The Pull Request

fixes various texts in thoughts,patrols, and events. pronoun tagging, verb tagging, m_c issues are fixed

Linked Issues

#1818 (comment)
#1818 (comment)
#1818 (comment)
#1818 (comment)
#1818 (comment)
#1818 (comment)
#1818 (comment)
#1818 (comment)
#1818 (comment)
#1818 (comment)
#2650
#1818 (comment)
#2693

Proof of Testing

image

image

Changelog/Credits

fixes some text errors

Copy link
Contributor

@keplerstelescope keplerstelescope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some edits! mostly edits to what was already there, rather than to what was changed in this PR. planning on making a PR to this with even more fixes to other bits of the code!

resources/dicts/patrols/beach/med/leaf-fall.json Outdated Show resolved Hide resolved
resources/dicts/patrols/general/medcat.json Outdated Show resolved Hide resolved
resources/dicts/patrols/general/medcat.json Show resolved Hide resolved
resources/dicts/patrols/general/medcat.json Show resolved Hide resolved
resources/dicts/thoughts/alive/general.json Outdated Show resolved Hide resolved
resources/dicts/thoughts/alive/general.json Outdated Show resolved Hide resolved
@selkirks selkirks marked this pull request as draft September 21, 2024 16:42
@keplerstelescope
Copy link
Contributor

related to this PR, is there a standard for how mossball/moss-ball should be written? in various bits of code, it's written as both of those, and a couple times as "moss ball" too

@selkirks
Copy link
Contributor Author

related to this PR, is there a standard for how mossball/moss-ball should be written? in various bits of code, it's written as both of those, and a couple times as "moss ball" too

i asked this a few hours ago in discord haha. its moss ball which i will fix

@selkirks selkirks marked this pull request as ready for review September 21, 2024 23:32
@scribblecrumb scribblecrumb merged commit 9d4d26a into ClanGenOfficial:development Sep 22, 2024
7 checks passed
@selkirks selkirks deleted the misc-fix branch September 26, 2024 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants