Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

terminate clients connecting from the wrong MC server #42

Open
Gjum opened this issue Jun 6, 2022 · 0 comments
Open

terminate clients connecting from the wrong MC server #42

Gjum opened this issue Jun 6, 2022 · 0 comments

Comments

@Gjum
Copy link
Member

Gjum commented Jun 6, 2022

MC server should already be sent in the Handshake, double check it's correct and never accidentally the previously joined server.

The server should continue to accept all MC servers by default (so it's up to the client to only fill in the Sync Server for the correct MC server(s)).
In addition, an environment variable should be able to be set, to reject all MC server addresses that don't match it.

Optionally, the comparison could be done by resolved IP address instead of comparing the hostname (there could be different hostnames for the same IP/MC server).

@Gjum Gjum added this to MapSync Jun 28, 2022
@Gjum Gjum moved this to Todo in MapSync Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

1 participant