Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(lints): unnecessary_string_escapes and prefer_function_declarations_over_variables rules #160
fix(lints): unnecessary_string_escapes and prefer_function_declarations_over_variables rules #160
Changes from 4 commits
453d4b4
94b7e8c
7229720
74a7a29
60b34c9
e0f919c
626396a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ignoring the rule might not be the best thing to do here. The rule says if you want to make functions then prefer proper declarations instead of creating variables. More info: https://dart-lang.github.io/linter/lints/prefer_function_declarations_over_variables.html
In our case we can simply avoid creating the variable for function since we just have 1 usage of that variable and instead we will simply use the function implementation where we need it.
Example,
From :
To:
(needs formatting)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay,I Will do that.
Thank you!