Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotate known addresses with names in solido multisig commands #362

Open
ruuda opened this issue Aug 16, 2021 · 0 comments
Open

Annotate known addresses with names in solido multisig commands #362

ruuda opened this issue Aug 16, 2021 · 0 comments
Labels
Milestone

Comments

@ruuda
Copy link
Contributor

ruuda commented Aug 16, 2021

Currently, output of solido multisig show-transaction looks like this:

Signers:
  [x] ENH1xvwjinUWkwEgw1hKduyAg7CrJMiKvr9nAS7wLHrp
  [x] DBd1yUhptC7yRq79sM4cAH1Zhe5rdTpJizxXJQGxRTyn
  [ ] J4RLjzbJUrm4vRk5ZpPpk6CHzrmAiZGDByuyJ8f9jXR7
  [x] 6S21QCmpAadEhHj3pY2RMbPMGwgYNvS4Pd7zUXoRDMdK
  [ ] CeuSTdUx4XnPET4K4o3Zxx3zjh1yrR4f8fyWycGjs7wj
  [ ] 6DzkRQ3CJXMdnwm9aS2ww7KNeKxw3YLANzpUeTFoRCtC
  [ ] F4VFp4tFTyrQWo9YVjCbPE5eQP27ice2zyGDp2tN2Rkm

This is technically correct, but not very helpful if you want to know who you need to ping. We could add a mapping from address to friendly name to the config file, and then it could render this instead:

  [x] Staking Facilities (ENH1xvwjinUWkwEgw1hKduyAg7CrJMiKvr9nAS7wLHrp)
  [x] Figment (DBd1yUhptC7yRq79sM4cAH1Zhe5rdTpJizxXJQGxRTyn)
  [ ] P2P (J4RLjzbJUrm4vRk5ZpPpk6CHzrmAiZGDByuyJ8f9jXR7)
  [x] Chorus One (6S21QCmpAadEhHj3pY2RMbPMGwgYNvS4Pd7zUXoRDMdK)
  [ ] Bonafida (CeuSTdUx4XnPET4K4o3Zxx3zjh1yrR4f8fyWycGjs7wj)
  [ ] Solana Foundation (6DzkRQ3CJXMdnwm9aS2ww7KNeKxw3YLANzpUeTFoRCtC)
  [ ] Saber (F4VFp4tFTyrQWo9YVjCbPE5eQP27ice2zyGDp2tN2Rkm)
@ruuda ruuda added good first issue Good for newcomers nice-to-have labels Aug 16, 2021
@ruuda ruuda added this to the V1 milestone Aug 16, 2021
@ruuda ruuda modified the milestones: V1, V3 Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant