Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] [Forge 1.20.1] Lithostitched dependency in mods.toml is only server side when it should be both #217

Open
Poopooracoocoo opened this issue Sep 29, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@Poopooracoocoo
Copy link

Poopooracoocoo commented Sep 29, 2024

Describe the bug
CTOV crashes on Forge when trying to generate a world in singleplayer without Lithostitched

https://github.com/ChoiceTheorem/ChoiceTheorem-s-overhauled-village/blob/master/forge/src/main/resources/META-INF/mods.toml#L53

https://github.com/ChoiceTheorem/ChoiceTheorem-s-overhauled-village/blob/1.20/neoforge/src/main/resources/META-INF/mods.toml

To Reproduce
Steps to reproduce the behaviour:

  1. Launch Forge instance with only CTOV
  2. Click on singleplayer

Expected behaviour
Change the dependency from side="SERVER" to side="BOTH" so that users are prompted to install it when they are missing the mod.

Mod loader
Forge 47.3.10

Minecraft Version
1.20.1

CTOV Version
3.4.9a

Add-ons used (Before 1.20)

Do you install Lithostitched?(1.20+)
No

Logs
latest.log
debug.log
crash-2024-09-30_09.04.33-client.txt

Additional context

This is not an issue on Minecraft 1.21 versions for NeoForge such as CTOV 3.5.3a.
https://github.com/ChoiceTheorem/ChoiceTheorem-s-overhauled-village/blob/1.21/neoforge/src/main/resources/META-INF/neoforge.mods.toml

While no versions of CTOV have been released for Forge on MC 1.21, it's still a server-sided dependency in the Forge mods.toml on the 1.21 branch.
https://github.com/ChoiceTheorem/ChoiceTheorem-s-overhauled-village/blob/1.21/forge/src/main/resources/META-INF/mods.toml

@Poopooracoocoo Poopooracoocoo added the bug Something isn't working label Sep 29, 2024
@Fealtous
Copy link

To be more specific, this is due to the SERVER dependency marker referring to physical sides, not logical sides. CTOV tends to work alone without Lithostitched, but when other mods are involved it consistently becomes an issue. Marking the dependency properly will solve the issue and allows neo/forge's dependency system to actually alert players when it's missing.

@Poopooracoocoo Poopooracoocoo changed the title [BUG] Lithostitched dependency in mods.toml is only server side when it should be both [BUG] [Forge 1.20.1] Lithostitched dependency in mods.toml is only server side when it should be both Sep 29, 2024
@ChoiceTheorem ChoiceTheorem added this to the Mod compatibilities milestone Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants