Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Outdated structures cause DFU to process every time they are loaded #124

Open
Linguardium opened this issue Apr 9, 2024 · 0 comments
Assignees
Labels
Refinement Something needed to be optimized

Comments

@Linguardium
Copy link

Describe the bug
When minecraft loads a structure template from nbt, it checks the DataVersion tag to see if it needs to be updated to the current version of minecraft, and if so it runs it through the data fixer upper to update it.

By providing outdated structure nbt files in your "mod", you force DFU to process any structure loaded from your mod, causing increased memory and cpu utilization.

CTOV Version

3.4.2

Add-ons used (Before 1.20)

Do you install Lithostitched?(1.20+)
Yes

Ideally, if you are building a fake mod anyway, it may be best to run the structures from a folder through DFU and write them back out to nbt during datagen so that any version you release matches the nbt you provide

@Linguardium Linguardium added the bug Something isn't working label Apr 9, 2024
@ChoiceTheorem ChoiceTheorem added Refinement Something needed to be optimized and removed bug Something isn't working labels Jun 8, 2024
@ChoiceTheorem ChoiceTheorem added this to the Complex refinement milestone Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Refinement Something needed to be optimized
Projects
None yet
Development

No branches or pull requests

2 participants