Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mobi/AZW3 meta #63

Merged
merged 6 commits into from
May 11, 2024
Merged

Mobi/AZW3 meta #63

merged 6 commits into from
May 11, 2024

Conversation

angelgarcia999
Copy link
Contributor

When adding a .mobi/.azw3 book it reads the metadata and grayscales the images within the files.

infinimineralex
infinimineralex requested changes May 11, 2024
View reviewed changes
Copy link
Contributor

@infinimineralex infinimineralex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, except for one part: it doesn't seem like AZW3 grayscaling is working. I see it adds correctly for both AZW3 and MOBI, but it doesn't seem to grayscale.

infinimineralex
infinimineralex approved these changes May 11, 2024
View reviewed changes
Copy link
Contributor

@infinimineralex infinimineralex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@infinimineralex infinimineralex merged commit 9aadb36 into main May 11, 2024
2 checks passed
@infinimineralex infinimineralex deleted the mobi_meta branch May 12, 2024 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinimineralex infinimineralex infinimineralex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@angelgarcia999 @infinimineralex