Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addendum to 100% block fill rate. #19006

Conversation

AmineKhaldi
Copy link
Contributor

@AmineKhaldi AmineKhaldi commented Dec 9, 2024

It's happening!
I mean, cough, this is an addendum to #19005.

@AmineKhaldi AmineKhaldi added Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Cleanup Code cleanup labels Dec 9, 2024
@AmineKhaldi AmineKhaldi self-assigned this Dec 9, 2024
@AmineKhaldi AmineKhaldi marked this pull request as ready for review December 9, 2024 16:24
@AmineKhaldi AmineKhaldi requested a review from a team as a code owner December 9, 2024 16:24
@hoffmang9
Copy link
Member

Woooooooooohooooooo!

@arvidn arvidn merged commit 84a5304 into Chia-Network:remove-block-fill-rate-limit Dec 9, 2024
297 of 298 checks passed
pmaslana pushed a commit that referenced this pull request Dec 12, 2024
* remove the block fill rate limit of 70% when farming a block

* Addendum to 100% block fill rate. (#19006)

* break down 'magic number' in test into its components

* Attempt to clarify why we add many aggsig conditions in make_and_send_big_cost_sb (#19026)

Attempt to clarify why we add many aggsig conditions in make_and_send_big_cost_sb.

---------

Co-authored-by: Amine Khaldi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Cleanup Code cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants