-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow users to ignore specific lines during kics-scan #4420
Comments
Regarding this issue this is the approach we are thinking of: Users would be able to use two comments as commands in order to ignore specific lines
kics ignore-blockThis command ignores the object and all its key-value pairs beneath the line of the command kics ignore-lineThis command ignores the line beneath the line of the command Dockerfile
Terraform
YAML
JSONIt is not possible to add this feature since JSON files don't support comments |
@joaoReigota1 It would be great ! |
Signed-off-by: João Reigota <[email protected]>
Signed-off-by: João Reigota <[email protected]>
Signed-off-by: João Reigota <[email protected]>
This does not work: Tried this: // kics ignore-block ####################### Log Bucket creation####################### Tried this: ################### Bucket creation################### ####################### Log Bucket creation####################### Still shows up in report |
@balq60 The comment needs to start with |
Describe the solution you'd like
Kics already allow users to disable scan on whole files. But for most cases, I think it would be more useful to just ignores lines of files and not the entire file.
From a security point of view, it's not because one line on my file could not be analysed that I want to exclude the rest of my file (that could hide some more security breaches).
Additional context
It could be useful for temporary issues and/or too specific context problem (could probably solve #4419)
The text was updated successfully, but these errors were encountered: