Skip to content
This repository has been archived by the owner on Feb 14, 2023. It is now read-only.

Remove Component and PureComponent from interface ReactN #89

Open
quisido opened this issue Jun 4, 2019 · 2 comments
Open

Remove Component and PureComponent from interface ReactN #89

quisido opened this issue Jun 4, 2019 · 2 comments
Labels
help wanted The owner cannot resolve this on their own.

Comments

@quisido
Copy link
Collaborator

quisido commented Jun 4, 2019

In src/index.ts, the ReactN interface should not have Component and PureComponent defined, as these are defined in the namespace in order to maintain their generics.

The existence of this interface property prevents class MyComponent extends React.Component from being used with no generics.

TravisCI fails to build if they are missing in the interface, despite the build succeeding locally.

Investigate potential TypeScript version conflicts (delete all node modules and try local build again?)

@quisido quisido added bug Something isn't working as expected. help wanted The owner cannot resolve this on their own. labels Jun 4, 2019
@quisido quisido added this to the 2.1.3 milestone Jun 4, 2019
@quisido quisido assigned quisido and unassigned quisido Jun 4, 2019
@quisido quisido modified the milestones: 2.1.3, 2.1.4 Jun 10, 2019
@Razaik25
Copy link

Hi,
If this issue is up for grabs, i can take it up. Please let me know.

@quisido
Copy link
Collaborator Author

quisido commented Aug 27, 2019

Anything marked [help wanted] is for grabs. I'm not sure the solution to this though! I think the goal is for 3.0 I'll drop the decorator support and not try to export React from the package itself, and TypeScript should automatically work without the magic of index.ts that exists today. Until then, getting the current definitions to work in a backwards compatible way is ideal. :)

@quisido quisido removed the bug Something isn't working as expected. label Nov 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
help wanted The owner cannot resolve this on their own.
Projects
None yet
Development

No branches or pull requests

2 participants