Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stacks should share the geometry objects #212

Open
hamogu opened this issue Aug 20, 2019 · 0 comments
Open

Stacks should share the geometry objects #212

hamogu opened this issue Aug 20, 2019 · 0 comments

Comments

@hamogu
Copy link
Member

hamogu commented Aug 20, 2019

Elements in a stack should share the same geometry object. I've come across user code (written by me, but outside of MARXS) where I tweaked the geometry object of a stack, but the change did not propagate down to the objects that make up a stack.
I'm not sure how to solve this. It's pretty easy if I just want to work with updates of the existing geometry object. In that case, the objects in the stack can just point all to that object. However, if the geometry object that the stack owns is replaced wit ha new one, how do I update all the other references?

Related to #118 which suggests relative geometry expressions.

@hamogu hamogu changed the title Stacks should shate the geometry objects Stacks should share the geometry objects Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant