Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ideas for Geometry improvements #181

Open
1 of 7 tasks
hamogu opened this issue Jun 1, 2018 · 1 comment
Open
1 of 7 tasks

Ideas for Geometry improvements #181

hamogu opened this issue Jun 1, 2018 · 1 comment

Comments

@hamogu
Copy link
Member

hamogu commented Jun 1, 2018

  • rename Finite-Plane to box and or half box?
  • add a triangulate method for boxes (essentially already existing in visualization.mayavi). They way, everything can be plotted as triangulation, which will make is easier to implement a minimal plotting backend, e.g. for vispay or direct OpenGL if Mayavi does not move to python 3 soon.
  • move some stuff from apertures to geometry
    • make a generic geometry PlanewithHole that has outer_display, order_edge, inner_edge (or None), inner_edge_display (or None, only makes sense if inner_edge not None). This is for plotting.
    • Can this generalize the generate_local_xy? I don't think that's worth the effort.
  • add triangulate method for Cylinders
  • add triangulate method for torus
  • rename classes that are now more general than their name (e.g. FlatGrating)
  • test FlatGrating with a Cylinder shape
@hamogu
Copy link
Member Author

hamogu commented Feb 25, 2019

Test of the FlatGRating with a patched shape shows the dangers of relying on dict (visualization) that's independent of the actual geometry that's plotted. That allows a shape that's different. In this case, I changed the center in pos4d for a Cylinder, but kept plotting "boxes" which directly uses the values in pos4d, not a function that the geometry supplies. Thus, it can be plotted, but won't show the cylinder. Need to think about how to controls these things more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant