Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: no get_experiment_results #84

Closed
jkitchin opened this issue Oct 8, 2024 · 1 comment · Fixed by #85
Closed

[Bug]: no get_experiment_results #84

jkitchin opened this issue Oct 8, 2024 · 1 comment · Fixed by #85
Labels
bug not't working as it should be

Comments

@jkitchin
Copy link
Contributor

jkitchin commented Oct 8, 2024

Current behavior

At https://cedergrouphub.github.io/alabos/submit_experiments.html#get-the-results it suggests you get results with

from alab_management import get_experiment_results

results = get_experiment_results(exp_id)

but this leads to

File "/Users/jkitchin/Dropbox/emacs/projects/projects/claude/alabos/examples/claude-light/get_results.py", line 4, in <module>
    from alab_management import get_experiment_results
ImportError: cannot import name 'get_experiment_results' from 'alab_management' (/Users/jkitchin/Dropbox/emacs/projects/projects/claude/alabos/alab_management/__init__.py)

Expected Behavior

Maybe it should be

from alab_management.builders.experimentbuilder import get_experiment_result

results = get_experiment_result('67053622de1c825bbd241f2d')
print(results)

I think the issue is in

from .builders import ExperimentBuilder, get_experiment_status
and
from .experimentbuilder import ExperimentBuilder, get_experiment_status
where that function is not imported.

Minimal example

No response

Relevant files/images/logs

No response

@jkitchin jkitchin added the bug not't working as it should be label Oct 8, 2024
@idocx
Copy link
Member

idocx commented Oct 8, 2024

Thank you for testing and reporting the bug! I have created a fix to correctly import. I also updated the function name in the document from get_experiment_results to get_experiment_result as it can only return one experiment result at a time.

That is, once the new update is merged, you should be able to use the following code (also updated in the document) to get the result.

from alab_managementimport get_experiment_result

results = get_experiment_result('67053622de1c825bbd241f2d')
print(results)

@idocx idocx linked a pull request Oct 8, 2024 that will close this issue
5 tasks
@idocx idocx closed this as completed in #85 Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug not't working as it should be
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants