-
-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Catima Import / Export: Move to background thread (ProgressDialog is deprecated, flow is buggy, crashes importing some online files) #513
Comments
I think for the first version using indeterminate progress in the notification is fine :) |
I've started working on this in #622, but it doesn't quite work as I'd like it yet. |
The current flow can also crash, for example when importing a large file from NextCloud, because Android punishes doing network on the main thread by throwing a
Note: This only happens with bigger files, my example 544 byte import does not trigger this, but my 1.4MB of real data does. Clearly, Android has set a time limit on doing network on the main thread and the 1.4MB import hits the time limit. |
While #513 needs to be fixed, this at very least prevents a crash with only mild user inconvenience in a not commonly used activity
The ProgressDialog with has been deprecated.
The Recommendation hint seems to be to use a Notification (can also show progress) and move the cancel option there.
That would also mean most imports go through cleanly without being ended by users, probably leaving cleaner Databases.
The text was updated successfully, but these errors were encountered: