Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate groups to proper unique id #1045

Open
3 tasks done
Altonss opened this issue Sep 23, 2022 · 2 comments · May be fixed by #1333
Open
3 tasks done

Migrate groups to proper unique id #1045

Altonss opened this issue Sep 23, 2022 · 2 comments · May be fixed by #1333
Assignees
@Altonss
Labels
type: enhancement New feature or request

Comments

@Altonss
Copy link
Contributor

Altonss commented Sep 23, 2022 •
edited
Loading

The following points a required for a migration to unique ids for groups:

  • Edit the LoyaltyCardDbGroups table to contain a new ID column that's an integer.
  • Edit the LoyaltyCardDbIdsGroups table to refer to the group ID instead of group name.
  • Migrate all current memberships to the new setup.

@TheLastProject thinks, the easiest way is to just create 2 temporary tables and then create the new stuff like it has been done at newVersion 10 in the DBHelper class.

Originally posted by @TheLastProject in #669 (comment)

These steps are needed, because the current situation is blocking for a good implementation of #669 for example.
@Altonss
Copy link
Contributor Author

Altonss commented Sep 23, 2022

Should the group names still all be distinct? For the moment it is not possible to create 2 "Test" groups, should this limitation remain?
By the way, @TheLastProject you could assign me to the issue, I'm currently working on it.

@Altonss Altonss mentioned this issue Sep 23, 2022
Closed
@TheLastProject
Copy link
Member

Should the group names still all be distinct? For the moment it is not possible to create 2 "Test" groups, should this limitation remain?

I think that makes sense, I don't really see any benefit for users to make 2 groups with the exact same name after all.

By the way, @TheLastProject you could assign me to the issue, I'm currently working on it.

Thanks for picking this up! :)

@TheLastProject TheLastProject added the type: enhancement New feature or request label Oct 1, 2022
@Altonss Altonss mentioned this issue Feb 7, 2023
Open
@obfusk obfusk linked a pull request Jun 1, 2023 that will close this issue
Draft
12 tasks
@obfusk obfusk mentioned this issue Oct 15, 2023
Open
49 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Altonss Altonss

Labels
type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

DB: migrate to unique IDs for groups obfusk/catima
2 participants
@TheLastProject @Altonss