Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Direct Policy Optimization #504

Open
Reichenbachian opened this issue Jun 12, 2023 · 4 comments · May be fixed by #556
Open

Direct Policy Optimization #504

Reichenbachian opened this issue Jun 12, 2023 · 4 comments · May be fixed by #556
Labels
feature request New feature or request

Comments

@Reichenbachian
Copy link

🚀 The feature, motivation, and pitch

Hey all! Appreciate the work.

Is there any word on whether DPO (direct policy optimization) will be integrated into the trlx library soon?

Alternatives

No response

Additional context

No response
@Reichenbachian Reichenbachian added the feature request New feature or request label Jun 12, 2023
@Forbu
Copy link

Forbu commented Jun 14, 2023

@Reichenbachian I think there is currently a version of DPO under review on the TRL lib if you want to check :
https://github.com/lvwerra/trl/pull/416/files#diff-5bbdb5d54108f2162b47bc54dc23c7b8e7744d2941118e60a44c161a4acc0ee8

@CSerxy
Copy link

CSerxy commented Jul 25, 2023

wonder if there is any updates regarding implementing dpo features in trlx, many thanks!

@maxreciprocate
Copy link
Collaborator

There hasn't been any updates regarding that. AFAIK nobody is currently working on it, so you can freely pick it up if you want!

@sandeepchittilla
Copy link

sandeepchittilla commented Jul 26, 2023 •
edited
Loading

Hi, is this something that is still open to work on? I would like to pick it up if that is okay :)

@CSerxy I've just forked and begun work on this feature, let me know if this conflicts with you

@sandeepchittilla sandeepchittilla linked a pull request Sep 14, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Add support for DPO sandeepchittilla/trlx
5 participants
@CSerxy @Reichenbachian @Forbu @maxreciprocate @sandeepchittilla