Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The filterMode Doesn't Update from includeAll to excludeAll #2126

Open
zackcl opened this issue Nov 22, 2024 · 2 comments · Fixed by #2131
Open

The filterMode Doesn't Update from includeAll to excludeAll #2126

zackcl opened this issue Nov 22, 2024 · 2 comments · Fixed by #2131
Assignees
Labels
bug Something isn't working priority: high High priority issue release 6.0

Comments

@zackcl
Copy link
Collaborator

zackcl commented Nov 22, 2024

Version where bug was found:
6.1.0

Describe the bug
When an experiment has no participants, the "filterMode" should be set to "excludeAll". This works as expected when an experiment is created without participants. However, once the "filterMode" is set to "includeAll" (by adding an "All" row to the Include table), it doesn't revert back to "excludeAll" after removing the "All" row from the Include table. I believe this issue should be addressed as a hotfix for v6.0 since it's crucial.

To Reproduce
Steps to reproduce the behavior:

  1. Create an experiment with no participants
  2. Open the "Network" tab in the browser inspector to see the response from the /api/experiments/single/{experimentId} endpoint
  3. Observe that the "filterMode" is set to "excludeAll" (expected behavior)
  4. Update the experiment by adding an "All" row to the Include table
  5. View the response from the /api/experiments/single/{experimentId} endpoint again
  6. Observe that the "filterMode" is set to "includeAll" (expected behavior)
  7. Update the experiment by removing the "All" row from the Include table
  8. View the response from the /api/experiments/single/{experimentId} endpoint again
  9. Observe that the "filterMode" remains set to "includeAll" when it should have updated to "excludeAll"
  10. Verify by making /api/v5/init and /api/v5/assign requests with any user ID to confirm that users are not being excluded

Expected behavior
The experiment's "filterMode" should update from "includeAll" to "excludeAll" when the "All" row is removed from the Include table.

Screen recording

filterMode.bug.720p.mov
@zackcl zackcl added bug Something isn't working priority: high High priority issue release 6.0 labels Nov 22, 2024
@Yagnik56 Yagnik56 self-assigned this Nov 22, 2024
@amurphy-cl amurphy-cl added this to the Program Increment PI14 milestone Nov 22, 2024
@zackcl
Copy link
Collaborator Author

zackcl commented Nov 22, 2024

I will investigate if there are any other experiments like "LiveHint AI - Tutorbot for MATHstream" that have no participants but have their "filterMode" set to "includeAll" on Prod UpGrade so that we can update them if needed.

@zackcl
Copy link
Collaborator Author

zackcl commented Nov 25, 2024

I've verified that the filterMode settings for all experiments on Production are correctly set.

@Yagnik56 Yagnik56 linked a pull request Nov 25, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority: high High priority issue release 6.0
Projects
Status: QA
Development

Successfully merging a pull request may close this issue.

3 participants