Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fortran compatibility #130

Closed
ElliottKasoar opened this issue May 19, 2024 · 2 comments · Fixed by #145
Closed

Fortran compatibility #130

ElliottKasoar opened this issue May 19, 2024 · 2 comments · Fixed by #145
Labels
documentation Improvements or additions to documentation

Comments

@ElliottKasoar
Copy link
Contributor

ElliottKasoar commented May 19, 2024 •
edited
Loading

We should probably explicitly state which Fortran standards we support.

Ideally, we might test against different standards, if that's possible (maybe via the -std gfortran compile flag - if so, we may want to open a separate issue, and keep this one focused on documentation)?
@ElliottKasoar ElliottKasoar added the documentation Improvements or additions to documentation label May 19, 2024
@jatkinson1000
Copy link
Member

My thoughts here are can we write something to test this automatically?

Like a workflow that iterates over the various standards and builds FTorch with different flags?

@ElliottKasoar ElliottKasoar mentioned this issue Jun 27, 2024
Merged
@jatkinson1000
Copy link
Member

Discussion with @TomMelt We will set FTorch to require Fortran 2008 in the documentation.
See comments on #145 for further development.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add tests for different Fortran standards ElliottKasoar/FTorch
2 participants
@ElliottKasoar @jatkinson1000