Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPK/PCK singleton structure now raising errors during compilation #162

Open
dahlend opened this issue Dec 4, 2024 · 1 comment
Open
Labels
backend Issue in the rust backend bug Something isn't working

Comments

@dahlend
Copy link
Collaborator

dahlend commented Dec 4, 2024

Rust intrinsically does not like the singletons kete uses.

In a recent update, they have officially started raising warnings when things are built the way that they are built here.
Due to a setting in kete, warnings of this type are automatically converted to errors, breaking compilation.

Realistically rust is 100% correct here, and kete is doing some funny business with memory, however the way it is currently built this is essentially impossible to cause issues unless someone does something with multi-threading and loading files simultaneously. Even then I am not convinced this will lead to issues.

Solutions

  • Add an #[allow] at the correct spot to suppress the warning (probably ok?).
  • Consider restructuring the singletons to make it more memory safe (definitely ok).
@dahlend dahlend added bug Something isn't working backend Issue in the rust backend labels Dec 4, 2024
dahlend added a commit that referenced this issue Dec 4, 2024
@dahlend dahlend closed this as completed in 356523b Dec 4, 2024
@dahlend dahlend reopened this Dec 4, 2024
@dahlend
Copy link
Collaborator Author

dahlend commented Dec 4, 2024

This is temporarily fixed by #161 by adding #[allow], but at some point it would be good to look at this in more depth.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Issue in the rust backend bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant