Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload video to server from the client app #177

Open
ed-snodgrass opened this issue Oct 1, 2021 · 12 comments
Open

Upload video to server from the client app #177

ed-snodgrass opened this issue Oct 1, 2021 · 12 comments
Assignees

Comments

@ed-snodgrass
Copy link
Collaborator

This will require some interaction with the backend server. Basically, once you've recorded your video there isn't a way to upload it. You can replay it. There may be functionality to do so within the admin application but I can't guarantee that.

@markstur
Copy link
Member

markstur commented Oct 1, 2021

the admin UI doesn't have any video upload. The server does have a REST endpoint and Watson Media integration. Also some use of an "uploads" directory for a temporary(?) file storage.

I'm not sure what client was used to test the upload endpoint. Probably postman. I don't remember ever seeing a web page w/ a test upload, but a developer might have used something like that before our current clients were built w/ Vue.js/React.js.

@github-actions
Copy link

github-actions bot commented Dec 1, 2021

👋 Hi! This issue has been marked stale due to inactivity. If no further activity occurs within the next 7 days, it will automatically be closed.

@github-actions github-actions bot added the Stale label Dec 1, 2021
@ed-snodgrass
Copy link
Collaborator Author

Commenting here too keep this issue open.

@github-actions
Copy link

github-actions bot commented Feb 2, 2022

👋 Hi! This issue has been marked stale due to inactivity. If no further activity occurs within the next 7 days, it will automatically be closed.

@github-actions github-actions bot added the Stale label Feb 2, 2022
@github-actions github-actions bot closed this as completed Feb 9, 2022
@github-actions github-actions bot moved this to Done in Truth Loop Feb 9, 2022
@demilolu demilolu reopened this Feb 10, 2022
@demilolu demilolu reopened this Feb 10, 2022
@demilolu demilolu removed the Stale label Feb 10, 2022
@demilolu demilolu moved this from Done to In Progress in Truth Loop Feb 10, 2022
@demilolu demilolu removed the status in Truth Loop Feb 10, 2022
@demilolu demilolu moved this to In Progress in Truth Loop Feb 10, 2022
@demilolu
Copy link
Contributor

demilolu commented Feb 10, 2022

notes:

  • share and cancel button should do it.
  • We need a new server to put the video on: perhaps not Watson Media?
  • We can perhaps use COS/S3/Postgres or FileSystem in meantime for local development. Let's look at Legit-Info's means of doing it
  • Create a new COS free tier account.
  • Keep track of usage

@demilolu
Copy link
Contributor

@alexmiller522

@ed-snodgrass
Copy link
Collaborator Author

ed-snodgrass commented Feb 17, 2022

https://github.com/Call-for-Code-for-Racial-Justice/Truth-Loop/blob/main/client/src/recordRoute/RecordRoute.js

The stopRecording function is responsible for stopping the audio/video recording and updating the state of the app so the user can record another video or watch the video they just recorded. It also calls the onRecordingStopped function where I expect we want to perform the action of saving the file. Or maybe we want a separate button so the user only "Uploads" the videos they are comfortable uploading

@markstur
Copy link
Member

share should upload it, cancel should not.

TBD: there could be some reasonable confirmation before sharing or losing a video (on cancel), but just doing a proper share (upload) and cancel (go back w/o upload) would be a good start.

@ed-snodgrass ed-snodgrass self-assigned this Mar 31, 2022
@ed-snodgrass
Copy link
Collaborator Author

My current plan is to add support for uploading to a firebase storage bucket. I'll provide a react component that performs the upload and a "sample" configuration. Eventually supporting multiple storage options (S3 is a likely next option).

I assume we'll want users to authenticate at some point so they can manage their videos and all that. I'll be thinking through ideas on how to associate videos to users without folks being able to identify other users' account ids but that may not be until after I get the base functionality (and documentation in the readme).

I'm also curious if we think we'll need an approval process (one that is transparent to the uploader so that folks can't deny content that they don't agree with).

@ed-snodgrass
Copy link
Collaborator Author

ed-snodgrass commented Apr 3, 2022

TODOs

  • Add firebase
  • Support upload of recorded video
  • Create a UUID for the filename and policy id for the path
  • store the information in db
  • Update the readme with instructions
  • Make sure videos are viewable (new issue maybe)

@github-actions
Copy link

github-actions bot commented Jun 3, 2022

👋 Hi! This issue has been marked stale due to inactivity. If no further activity occurs within the next 7 days, it will automatically be closed.

@ed-snodgrass
Copy link
Collaborator Author

Commenting to maybe keep this from going stale. I need to wrap this thing up though. 😬

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress
Development

No branches or pull requests

3 participants