Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create GitHub actions to test any code before merging #48

Open
12 tasks
upkarlidder opened this issue Sep 26, 2021 · 9 comments
Open
12 tasks

Create GitHub actions to test any code before merging #48

upkarlidder opened this issue Sep 26, 2021 · 9 comments

Comments

@upkarlidder
Copy link
Member

upkarlidder commented Sep 26, 2021

Background on the problem the feature will solve/improved user experience

Add GitHub Actions to test and build new code pushed to a branch or committed to a pull request. Code that passes all the steps in the GitHub action can be merged in the repository.

Describe the solution you'd like

A GitHub action runs whenever code is committed to any branch or PR is made to the main branch for each of the following components:

  • website folder
  • mobile folder
  • backend folder

Refer to a similar action that was implemented for the UI folder in Five Fifths Voter project.

Each action will

  • install dependencies
  • build for production
  • run all tests
  • linting with prettier. Discuss with the team on what linter to use.

Tasks

Acceptance Criteria

GitHub action runs for every new code commit and PR.

FYI @demilolu

@upkarlidder upkarlidder changed the title Roadmap Template Create GitHub actions to test any code before merging Sep 26, 2021
@upkarlidder upkarlidder added good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed labels Sep 26, 2021
@ghost
Copy link

ghost commented Oct 4, 2021

Hi, I would like to work on this issue

@demilolu
Copy link
Contributor

demilolu commented Oct 4, 2021

@arianahl go for it!

@ghost ghost mentioned this issue Oct 5, 2021
12 tasks
@ghost
Copy link

ghost commented Oct 5, 2021

@demilolu the pull request adds the git actions requested. A few things I would like to point out:

  1. backend and website don't have tests so I left that line commented out
  2. backend and mobile don't have lint configured so I left that line commented out
  3. website has lint but it is misconfigured and gives many errors when running

Are these known issues?

@demilolu
Copy link
Contributor

demilolu commented Oct 6, 2021

@arianahl
I think 1 and 2 are, but I'm not sure about 3.

@upkarlidder @Jamstew2 insight here?

@upkarlidder
Copy link
Member Author

For 3, are you able to fix the errors @arianahl. That would be ideal.

@ghost
Copy link

ghost commented Oct 7, 2021

@upkarlidder If no one is working on the website part of the code I can give it go. Otherwise they would get a horrible merge on their hands.
Also a way to make it less intrusive is to change the current lint rule for parentheses: instead of having them on the next line leave them in the same line as most of the code already does. Actually this is only a problem in the index.js script. The rest of the files do follow allman style.
I can also go ahead and turn it on for the other two folders (different PR?).

@upkarlidder
Copy link
Member Author

@upkarlidder If no one is working on the website part of the code I can give it go. Otherwise they would get a horrible merge on their hands. Also a way to make it less intrusive is to change the current lint rule for parentheses: instead of having them on the next line leave them in the same line as most of the code already does. Actually this is only a problem in the index.js script. The rest of the files do follow allman style. I can also go ahead and turn it on for the other two folders (different PR?).

It sounds good to me. @Jamstew2 and team can you please provide some guidance as well?

@ghost ghost mentioned this issue Oct 7, 2021
12 tasks
@ghost
Copy link

ghost commented Oct 7, 2021

@upkarlidder I fixed the linting issues as part of pull request #62 which adds to #61. I made sure the actions are still passing.
Given the many changes I would recommend a thorough review from someone that knows the code just in case. I did test the website locally and I couldn't see any errors.

@demilolu
Copy link
Contributor

demilolu commented Nov 15, 2021

@kyleni are you able to review the related PRs please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants