Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor bug in rv multipanel plot #350

Open
zhexingli opened this issue Aug 15, 2021 · 3 comments
Open

Minor bug in rv multipanel plot #350

zhexingli opened this issue Aug 15, 2021 · 3 comments
Assignees
Labels

Comments

@zhexingli
Copy link
Contributor

There's a small bug when displaying the derived mpsini in the rv multipanel plot. See attached.

The derived mpsini is something like 0.1 solar mass but in the plot it displays 30 solar masses for some reasons

HD173902_radvel_results.pdf

A unrelated question.... in the derived_quantiles.csv file, is the unit for 'mpsini' always in Earth unit? What's 'musini' and what's the unit for it? Ty.

@bjfultn
Copy link
Contributor

bjfultn commented Sep 10, 2021

Yes, I believe mpsini is always in Earth units and musini is the mass ratio.

I'll try to track down that other little bug.

@bjfultn bjfultn self-assigned this Sep 10, 2021
@bjfultn bjfultn added the bug label Sep 10, 2021
@sealauren
Copy link
Contributor

This bug is still here (multipanel plot legend displays ~30 solar masses; should be 0.1 solar masses) -- I just saw it crop up in a similar case to what zhexingli described.

@bjfultn
Copy link
Contributor

bjfultn commented Dec 17, 2021

I looked into this for a few min, but I couldn't quickly find the culprit. @sealauren perhaps a student has time to dig into it and search for the bug?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants