Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import fails without h5py #345

Open
mileslucas opened this issue Apr 27, 2021 · 2 comments
Open

import fails without h5py #345

mileslucas opened this issue Apr 27, 2021 · 2 comments
Assignees

Comments

@mileslucas
Copy link

As noted in nespinoza/juliet#53 radvel doesn't install h5py within setup.py 117d4e6

This means a clean install (from inside a docker container)

$ pip install radvel

will fail to import

>>> import radvel
[...]
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/local/lib/python3.7/site-packages/radvel/__init__.py", line 16, in <module>
    from .mcmc import *
  File "/usr/local/lib/python3.7/site-packages/radvel/mcmc.py", line 12, in <module>
    import h5py
ModuleNotFoundError: No module named 'h5py'

If h5py is pip installed, too, import works fine.

@bjfultn
Copy link
Contributor

bjfultn commented Apr 27, 2021

This had to be temporarily removed due to a build problem on ReadTheDocs. They can't install h5py and can't build the docs without it. Once they fix that issue then I'll add it back into the requirements, but for now your solution to install separately is the best we can do. If this is not fixed within a week or two I'll add a note to the install documentation.

@mileslucas
Copy link
Author

Seems totally reasonable and understandable; thanks for the quick response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants