Classes with a $ in sources have names and references unintentionally changed

[i509VCB]

So I discovered this while using mercury to update CraftFabric (https://github.com/tr7zw/CraftFabric) to the latest yarn mappings.

So one example class was class CraftScoreboard$2 implements Function<net.minecraft.scoreboard.Team, Team>

Now i agree this is definitely some very odd naming, but I'll continue. So I pushed the sources through mercury and the outputted result ends up as class 2 implements...

Furthermore some constructors were outputted incorrectly, such as the following:

CraftScoreboard$2(CraftScoreboard var1) {
    this.this$0 = var1;
}

where it becomes

(CraftScoreboard var1) {
    this.this$0 = var1;
}

Also some references were unintentionally changed, such as new CraftScoreboard$2(this) -> new 2(this)

[jamierocks]

This was actually a known bug, and was actually the cause behind Sponge moving away from using the $ character in their class names.

The bug is caused by Lorenz treating the $ character as a delimeter for inner classes beyond just format implementation, which is to no consequence until you introduce source remapping into the ecosystem :(

At the time of Sponge's big remapping, I didn't really have the time to make any changes to Lorenz to resolve this - nor was I satisfied that any change wouldn't bring back the format implementations (and helpers) we had in Nocturne - with that said, I have a design in mind that could be used that could be used here.