Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate vocadb-openapi-client-java in favour of vocadb-openapi-dto-java #90

Open
CXwudi opened this issue Dec 21, 2023 · 2 comments
Open
Assignees

Comments

@CXwudi
Copy link
Owner

CXwudi commented Dec 21, 2023

Instead of generating the whole client, just generate the DTOs is better and allow users to use whatever client they want

However, it is shown that our hack of allowing Enum class name ended with "s" to support multiple unique enum value is necessary. Because in API call, such as GET /api/songs with the parameter fields, It must be a column separated list with unique elements like fields=tags,pvs. Using something else like fields=tags&fields=pvs won't work

We are also fixed in Jackson because the model is problematic with Gson, see https://github.com/CXwudi/vocadb-openapi-java-client-autofixer#before-generate

@CXwudi CXwudi changed the title Deprecate vocadb-openapi-client-java in favour of vocadb-openapi-dto Deprecate vocadb-openapi-client-java in favour of vocadb-openapi-dto-java Dec 21, 2023
@CXwudi
Copy link
Owner Author

CXwudi commented Dec 21, 2023

To generate the model only, we can reuse the command we have in https://github.com/VocaDB/vocadb-openapi-client-java but add --global-property models, see OpenAPITools/openapi-generator#12754 (comment)

However, not sure if it works for us

@CXwudi
Copy link
Owner Author

CXwudi commented Jan 14, 2024

Actually, is it possible that Maven/Gradle excluding transitive dependencies would be enough?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

1 participant