Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove easy-batch, but observe the batch pattern #27

Open
CXwudi opened this issue Jul 26, 2022 · 1 comment
Open

Remove easy-batch, but observe the batch pattern #27

CXwudi opened this issue Jul 26, 2022 · 1 comment
Labels
refactor optimization or enhancement of existing features or codebase wontfix This will not be worked on

Comments

@CXwudi
Copy link
Owner

CXwudi commented Jul 26, 2022

Since #3, we are only using the reader, processor and writer classes, and manually build and run the batch processing.

Then there is no need to use explicitly easy-batch's reader, processor and writer classes as it introduce too much overhead of wrapping and unwrapping the Record class.

@CXwudi CXwudi added the wontfix This will not be worked on label Aug 8, 2022
@CXwudi
Copy link
Owner Author

CXwudi commented Nov 23, 2022

Nor do we really need the Record class's order field as we have our own order field in VSongLabel class

@CXwudi CXwudi added enhancement New feature or request refactor optimization or enhancement of existing features or codebase and removed enhancement New feature or request labels Dec 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor optimization or enhancement of existing features or codebase wontfix This will not be worked on
Projects
Development

No branches or pull requests

1 participant