Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: add sphinx analytics dependency #1711

Merged
merged 1 commit into from
Dec 4, 2024
Merged

deps: add sphinx analytics dependency #1711

merged 1 commit into from
Dec 4, 2024

Conversation

CalMacCQ
Copy link
Contributor

@CalMacCQ CalMacCQ commented Dec 4, 2024

Description

Enables sphinx analytics for the docs site.

Configuration file was updated here -> CQCL/pytket-docs-theming#10

@CalMacCQ CalMacCQ requested a review from cqc-melf December 4, 2024 14:57
Copy link
Contributor

@cqc-melf cqc-melf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has this been discussed somewhere that we want to use this? Not sure what the legal implication are from adding google analytics? Do we need a cookie banner?

@CalMacCQ
Copy link
Contributor Author

CalMacCQ commented Dec 4, 2024

Has this been discussed somewhere that we want to use this? Not sure what the legal implication are from adding google analytics? Do we need a cookie banner?

Resolved separately

@CalMacCQ CalMacCQ merged commit 8108de9 into main Dec 4, 2024
30 checks passed
@CalMacCQ CalMacCQ deleted the sphinx_analytics branch December 4, 2024 16:04
CalMacCQ added a commit that referenced this pull request Dec 4, 2024
CalMacCQ added a commit that referenced this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants