Fix implementations of symbol_substitution() for boxes that cannot contain symbols. #1004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yao-cqc
reviewed
Sep 5, 2023
Comment on lines
48
to
51
| Op_ptr symbol_substitution( | ||
| const SymEngine::map_basic_basic &) const override { | ||
| return Op_ptr(); | ||
| return std::make_shared<ConjugationBox>(compute_, action_, uncompute_); | ||
| } |
There was a problem hiding this comment.
ConjugationBox should support symbols, but we can fix it in a separate PR
There was a problem hiding this comment.
Made an issue and added a comment.
Good idea: done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were just returning a null
Op_ptr.Fixes #999 .