Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rdrsv2.1 sometimes does not crop to the full extent of the input Shapefile #48

Open
kasra-keshavarz opened this issue May 16, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@kasra-keshavarz
Copy link
Collaborator

Sometimes the cropped RDRSv2.1 grid cells to not entirely cover the requested domain. An example is below:
image

As a quick solution, a value of 0.1 degree could be added/subtracted given the maximum/minimum latitude and longitude values. This is a quick solution and a better one needs to be implemented to crop the extents seamlessly.

@kasra-keshavarz kasra-keshavarz added the bug Something isn't working label May 16, 2024
@kasra-keshavarz kasra-keshavarz self-assigned this May 16, 2024
@kasra-keshavarz
Copy link
Collaborator Author

Resolved with #50

@kasra-keshavarz
Copy link
Collaborator Author

kasra-keshavarz commented Jul 3, 2024

Reopening this issue as @wknoben had faced another issue with the tool and the spatial extents:

Hi Kasra, I think there may be issues with RDRS too. This image is what I get when I feed the datatool subsets into easymore. Even though EASYMORE cannot use the outer edges (so there is one outer ring of grid cells missing), it seems to me that what datatool has returned :
Extends too far North/South
Is too narrow East/West > I expect even if EASYMORE could use the outer grid cells the far east part of this basin would still be outside the areas that datatool has found.
Would you agree with this or am I missing something here?

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant