New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

performance: generics support #18

Open

mathisdrn opened this issue Aug 25, 2023 · 0 comments

Assignees

Labels

Contributor

mathisdrn commented Aug 25, 2023

Define Type generic : numeric, text, bool, undefined (being nil value of string).
Load lines of jsonlines till colType is known for every columns, if a colType is undefined : log.warn() + load value as []undefined
Load lines and append to a list of said type.
Use []T throughout construction of MainMetric()
Use []numericT, []textT, []boolT as type signature input of SetTypeMetric()

Scope of impact :

performance gain : []interface{} is slow and type assertion v.(type) is used in a lot of functions. Generics will remove this need.
typed data : less error

mathisdrn added the enhancement label

mathisdrn self-assigned this

mathisdrn changed the title ~~generics support~~ performance: generics support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment