Scheduler and plannings management #3247
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3247 +/- ##
==========================================
+ Coverage 83.12% 84.70% +1.57%
==========================================
Files 327 328 +1
Lines 12428 12525 +97
Branches 980 993 +13
==========================================
+ Hits 10331 10609 +278
+ Misses 1807 1606 -201
- Partials 290 310 +20 ☔ View full report in Codecov by Sentry. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| foreach (var layer in Layers.Where(layer => layer.Planning == planningId)) | ||
| { | ||
| var updatedLayer = FindLayer(layer.Id); | ||
| updatedLayer.Planning = null; | ||
| await LayerClientService.UpdateLayer(updatedLayer); | ||
| } |
Check notice
Code scanning / CodeQL
Missed opportunity to use Select Note
src/IoTHub.Portal.Infrastructure/Jobs/SendPlanningCommandJob.cs
Dismissed
Show dismissed
Hide dismissed
| foreach (var schedule in schedules) | ||
| { | ||
| // Add schedules to the planning | ||
| if (schedule.PlanningId == planningCommand.planningId) addSchedule(schedule, planningCommand); | ||
| } |
Check notice
Code scanning / CodeQL
Missed opportunity to use Where Note
|
|
||
| var mockScheduleList = Fixture.CreateMany<ScheduleDto>(2).ToList(); | ||
|
|
||
| var deviceModels = Fixture.CreateMany<DeviceModelDto>(2).ToList(); |
Check warning
Code scanning / CodeQL
Useless assignment to local variable Warning
| var expectedPaginatedDeviceModels = new PaginationResult<DeviceModelDto>() | ||
| { | ||
| Items = mockDeviceModel.ToList(), | ||
| TotalItems = mockDeviceModel.Count | ||
| }; |
Check warning
Code scanning / CodeQL
Useless assignment to local variable Warning
| public async Task LinkDeviceLayerDialog_Search_RendersCorrectlyAsync() | ||
| { | ||
| // Arrange | ||
| var searchedDevices = Fixture.CreateMany<TableData<DeviceListItem>>(3).ToList(); |
Check warning
Code scanning / CodeQL
Useless assignment to local variable Warning
| public async Task LinkDeviceLayerDialog_Search_ShouldDisplayDevicesAsync() | ||
| { | ||
| // Arrange | ||
| var searchedDevices = Fixture.CreateMany<TableData<DeviceListItem>>(3).ToList(); |
Check warning
Code scanning / CodeQL
Useless assignment to local variable Warning
| public async Task LinkDeviceLayerDialog_Save_UpdatesDevices() | ||
| { | ||
| // Arrange | ||
| var searchedDevices = Fixture.CreateMany<TableData<DeviceListItem>>(3).ToList(); |
Check warning
Code scanning / CodeQL
Useless assignment to local variable Warning
src/IoTHub.Portal.Infrastructure/Jobs/SendPlanningCommandJob.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Kevin BEAUGRAND <[email protected]>
|
@judramos I'll close this PR to move it to another branch for vnext, don't worry. |
Description
What's new?
What kind of change does this PR introduce?