Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wind in km/h #374

Closed
y0m1g opened this issue May 13, 2024 · 3 comments
Closed

Wind in km/h #374

y0m1g opened this issue May 13, 2024 · 3 comments

Comments

@y0m1g
Copy link
Contributor

y0m1g commented May 13, 2024

Hello,

I may be mistaking or have missed a configuration somewhere, but I believe the wind unit is hardcoded to m/s:

return value.toFixed(0)// + ' m/s'

(my locale is fr-CA and units is set to metric in MM config)

Could it be possible to add an option to display in km/h instead?

Thanks a lot for the great work on this plugin!

@CFenner
Copy link
Owner

CFenner commented May 13, 2024

See #24

@y0m1g
Copy link
Contributor Author

y0m1g commented May 13, 2024

Even though user-prefered units are still to implement, the current wind unit is wrong: #374

@y0m1g y0m1g reopened this May 13, 2024
@CFenner
Copy link
Owner

CFenner commented Jun 24, 2024

Thanks for the PR, will try to have a look at the user-preferred units.

@CFenner CFenner closed this as completed Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants