New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move language internationalization code to deps #76

Open

tobiasnteireho opened this issue Dec 14, 2023 · 0 comments

Collaborator

tobiasnteireho commented Dec 14, 2023

The i18n code is common to author and viewer but is duplicated in both code-bases and probably should be put in deps.

https://github.com/CCALI/a2jviewer/blob/c9497a1e22a4bc6b8c1aa9e1308c67b509ed95c6/src/mobile/util/tlang.js#L95

https://github.com/CCALI/a2jauthor/blob/9b4a30f8dfb00a1099adbbfa9a90d135650a9577/legacy/viewer/A2J_Languages.js#L163

tobiasnteireho changed the title ~~Move tlang.js to deps~~ Move language internationalization code to deps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment