-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#58 battleシーンのstateつくる #61
The head ref may contain hidden characters: "#58-Battle\u30B7\u30FC\u30F3\u306EState\u3064\u304F\u308B"
Conversation
各ウィンドウのState、ウィンドウ内での選択、次のウィンドウに進む、前のウィンドウに戻る、の機能の実装 デバッグ画面での正常動作確認済み
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BattleDebug~~~StatePresenter
と BattleDebug~~~StateUseCase
ですべての状態でスクリプトを分けていますが、全部1個でまとめていいと思いますよ。
BattleDebugStatePresenter
と BattleDebugStateUseCase
とかにですね
もちろん Presenterには複数のボタンが含まれることになるし、UseCase にも Initializeがでかくなります
{ | ||
public class BattleStateMachineUseCase : IBattleStateMachineUseCase | ||
{ | ||
private BattleStateMachinePresenter _battleStateMachinePresenter = new BattleStateMachinePresenter(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ここ new じゃなくて VContainer から Inject するのではないですか?
1.BattleDebugStatePresenterとBattleDebugStateUseCaseを新規に作成し、各状態のスクリプトをまとめました |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!!
Battleシーンでのコマンド選択の状態遷移を全部つくりました