Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#58 battleシーンのstateつくる #61

Merged
merged 4 commits into from
Aug 29, 2024

Conversation

ujisuke
Copy link
Collaborator

@ujisuke ujisuke commented Aug 9, 2024

Battleシーンでのコマンド選択の状態遷移を全部つくりました

各ウィンドウのState、ウィンドウ内での選択、次のウィンドウに進む、前のウィンドウに戻る、の機能の実装
デバッグ画面での正常動作確認済み
Copy link
Collaborator

@AiletS AiletS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BattleDebug~~~StatePresenterBattleDebug~~~StateUseCase ですべての状態でスクリプトを分けていますが、全部1個でまとめていいと思いますよ。

BattleDebugStatePresenterBattleDebugStateUseCase とかにですね
もちろん Presenterには複数のボタンが含まれることになるし、UseCase にも Initializeがでかくなります

{
public class BattleStateMachineUseCase : IBattleStateMachineUseCase
{
private BattleStateMachinePresenter _battleStateMachinePresenter = new BattleStateMachinePresenter();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ここ new じゃなくて VContainer から Inject するのではないですか?

@ujisuke
Copy link
Collaborator Author

ujisuke commented Aug 14, 2024

1.BattleDebugStatePresenterとBattleDebugStateUseCaseを新規に作成し、各状態のスクリプトをまとめました
2.new→Injectに変更しました

Copy link
Collaborator

@AiletS AiletS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

@ujisuke ujisuke merged commit 7343df3 into main Aug 29, 2024
2 checks passed
@ujisuke ujisuke deleted the #58-BattleシーンのStateつくる branch August 29, 2024 14:15
@dugite-git dugite-git linked an issue Aug 29, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BattleシーンのStateつくる
3 participants