Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

color profile of the chrome browser #92

Open
kswang1029 opened this issue Mar 23, 2023 · 3 comments
Open

color profile of the chrome browser #92

kswang1029 opened this issue Mar 23, 2023 · 3 comments
Labels
question Further information is requested
Milestone

Comments

@kswang1029
Copy link
Contributor

Users may run the same script to generate a PNG image plot on different platforms (eg macOS and ubuntu linux). The color profile of the rendered PNG may be different. It may be a good idea to add --force-color-profile=srgb when we initialize the headless chrome so that in principle, we will see the same rendered PNGs. Would this be sensible? @veggiesaurus @confluence @YuHsuan-Hwang

@kswang1029 kswang1029 added the question Further information is requested label Mar 23, 2023
@veggiesaurus
Copy link
Collaborator

that's a good point. makes sense to use srgb

@confluence
Copy link
Collaborator

I don't know if it makes sense to hardcode this into the options -- but maybe we should. In the meantime, it is possible to pass additional flags to the browser in the existing code:

session = Session.start_and_create(Chrome(options=["--force-color-profile=srgb"]))

@kswang1029
Copy link
Contributor Author

I don't know if it makes sense to hardcode this into the options -- but maybe we should. In the meantime, it is possible to pass additional flags to the browser in the existing code:


session = Session.start_and_create(Chrome(options=["--force-color-profile=srgb"]))

With same data and same script, we should get same png output on different machines. I am not sure if, for example, matplotlib behaves like that as there are different backends to use. 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
No open projects
Status: Icebox
Development

No branches or pull requests

3 participants